linux-kernel - Re: [v4,1/1] hwmon: (nct7904) Add watchdog function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUesEMsWH55Tfe+eru8iVpgWbKPnL-wgRakG9BEpP4Y1g@mail.gmail.com>
Date:   Tue, 2 Jun 2020 10:01:41 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     yuechao.zhao@...antech.com.cn
Cc:     345351830@...com, Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-hwmon@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        amy.shih@...antech.com.tw, oakley.ding@...antech.com.tw,
        jia.sui@...antech.com.cn, shengkui.leng@...antech.com.cn
Subject: Re: [v4,1/1] hwmon: (nct7904) Add watchdog function

Hi Yuechao,

On Tue, Mar 31, 2020 at 7:30 AM <yuechao.zhao@...antech.com.cn> wrote:
> From: Yuechao Zhao <yuechao.zhao@...antech.com.cn>
>
> implement watchdong functionality into the "hwmon/nct7904.c"
>
> Signed-off-by: Yuechao Zhao <yuechao.zhao@...antech.com.cn>

Thanks for your patch, which is now commit 77849a552d142ef5 ("hwmon:
(nct7904) Add watchdog function").

> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1340,10 +1340,12 @@ config SENSORS_NCT7802
>
>  config SENSORS_NCT7904
>         tristate "Nuvoton NCT7904"
> -       depends on I2C
> +       depends on I2C && WATCHDOG
> +       select WATCHDOG_CORE

This makes the driver unselectable if WATCHDOG is not set.

Is there a use case for using this driver without watchdog functionality?
If yes, it might make sense to make the watchdog support optional,
protected by #ifdef CONFIG_WATCHDOG, and change the above to

    depends on I2C
    select WATCHDOG_CORE if WATCHDOG

If no, please ignore my email.

>         help
>           If you say yes here you get support for the Nuvoton NCT7904
> -         hardware monitoring chip, including manual fan speed control.
> +         hardware monitoring chip, including manual fan speed control
> +         and support for the integrated watchdog.
>
>           This driver can also be built as a module. If so, the module
>           will be called nct7904.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds