linux-kernel - Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfi5nDgwT10J_EKYn90vGuiL1hyfre+t_w_OFREFY-Tqg@mail.gmail.com>
Date:   Tue, 2 Jun 2020 11:31:54 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Tony Lindgren <tony@...mide.com>,
        Peter Hurley <peter@...leysoftware.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Merlijn Wajer <merlijn@...zup.org>,
        Pavel Machek <pavel@....cz>, Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl
 if inactive

On Tue, Jun 2, 2020 at 11:09 AM Johan Hovold <johan@...nel.org> wrote:
> On Mon, Jun 01, 2020 at 05:18:13PM -0700, Tony Lindgren wrote:

...

> There's shouldn't be anything fundamental preventing you from adding the
> missing resume calls to the mctrl paths even if it may require reworking
> (and fixing) the whole RPM implementation (which would be a good thing
> of course).

Yes, for serial core I have long standing patch series to implement
RPM (more or less?) properly.

However, OMAP is a beast which prevents us to go due to a big hack
called pm_runtime_irq_safe().
Tony is aware of this and I think the above is somehow related to removal of it.

But I completely agree that the goal is to get better runtime PM
implementation over all.

-- 
With Best Regards,
Andy Shevchenko