[<prev] [next>] [day] [month] [year] [list]
Message-ID: <8ea80af8-e964-4488-25c6-837f2ac88493@web.de>
Date: Tue, 2 Jun 2020 11:05:07 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Navid Emamdoost <navid.emamdoost@...il.com>,
linux-spi@...r.kernel.org
Cc: Navid Emamdoost <emamd001@....edu>, Kangjie Lu <kjlu@....edu>,
Stephen McCamant <smccaman@....edu>,
Qiushi Wu <wu000273@....edu>,
Baolin Wang <baolin.wang7@...il.com>,
Mark Brown <broonie@...nel.org>,
Orson Zhai <orsonzhai@...il.com>,
Chunyan Zhang <zhang.lyra@...il.com>,
Dinghao Liu <dinghao.liu@....edu.cn>,
LKML <linux-kernel@...r.kernel.org>,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] spi: sprd: call pm_runtime_put if pm_runtime_get_sync
fails
> Call to pm_runtime_get_sync increments counter even in case of
> failure leading to incorrect ref count.
> Call pm_runtime_put_noidle if pm_runtime_get_sync fails.
How do you think about a wording variant like the following?
Change description:
The PM runtime reference counter is generally incremented by a call of
the function “pm_runtime_get_sync”.
Thus call the function “pm_runtime_put_noidle” also in one error case
to keep the reference counting consistent.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
Powered by blists - more mailing lists