lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Jun 2020 13:13:46 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Christophe JAILLET <christophe.jaillet@...adoo.fr> Cc: aisheng.dong@....com, festevam@...il.com, shawnguo@...nel.org, stefan@...er.ch, kernel@...gutronix.de, linus.walleij@...aro.org, s.hauer@...gutronix.de, linux-imx@....com, gary.bisson@...ndarydevices.com, linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()' On Sat, May 30, 2020 at 10:49:55PM +0200, Christophe JAILLET wrote: > 'pinctrl_unregister()' should not be called to undo > 'devm_pinctrl_register_and_init()', it is already handled by the framework. > > This simplifies the error handling paths of the probe function. > The 'imx_free_resources()' can be removed as well. > > Fixes: a51c158bf0f7 ("pinctrl: imx: use radix trees for groups and functions") > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > --- You didn't introduce this but the: ipctl->input_sel_base = of_iomap(np, 0); should be changed to devm_of_iomap(). regards, dan carpenter
Powered by blists - more mailing lists