linux-kernel - Re: [PATCH 05/15] crypto: inside-secure - use PCI_IRQ_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159109756912.870467.7291427996953916910@kwain>
Date:   Tue, 02 Jun 2020 13:32:49 +0200
From:   Antoine Tenart <antoine.tenart@...tlin.com>
To:     "David S . Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Piotr Stankiewicz <piotr.stankiewicz@...el.com>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        Piotr Stankiewicz <piotr.stankiewicz@...el.com>
Subject: Re: [PATCH 05/15] crypto: inside-secure - use PCI_IRQ_MSI_TYPES where appropriate

Hello Piotr,

Quoting Piotr Stankiewicz (2020-06-02 11:20:19)
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
> 
> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@...el.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

Reviewed-by: Antoine Tenart <antoine.tenart@...tlin.com>

Thanks,
Antoine

> ---
>  drivers/crypto/inside-secure/safexcel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
> index 2cb53fbae841..1b2faa2a6ab0 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -1567,7 +1567,7 @@ static int safexcel_probe_generic(void *pdev,
>                 ret = pci_alloc_irq_vectors(pci_pdev,
>                                             priv->config.rings + 1,
>                                             priv->config.rings + 1,
> -                                           PCI_IRQ_MSI | PCI_IRQ_MSIX);
> +                                           PCI_IRQ_MSI_TYPES);
>                 if (ret < 0) {
>                         dev_err(dev, "Failed to allocate PCI MSI interrupts\n");
>                         return ret;
> -- 
> 2.17.2
> 

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com