lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Jun 2020 13:50:50 +0200 From: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> To: linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org Cc: linux-kernel@...r.kernel.org, linux-m68k <linux-m68k@...ts.linux-m68k.org>, Al Viro <viro@...iv.linux.org.uk>, Geert Uytterhoeven <geert@...ux-m68k.org> Subject: [PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support On 5/14/20 10:21 PM, Geert Uytterhoeven wrote: > These #ifdefs are relics from APUS (Amiga Power-Up System), which > added a PPC board. APUS support was killed off a long time ago, > when arch/ppc/ was still king, but these #ifdefs were missed, because > they didn't test for CONFIG_APUS. Add FIXME about using the C code variants (APUS ones) in the future. Reported-by: Al Viro <viro@...iv.linux.org.uk> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> --- v2: - added FIXME comment instead of removing the C code variants drivers/video/fbdev/amifb.c | 6 ++++++ 1 file changed, 6 insertions(+) Index: b/drivers/video/fbdev/amifb.c =================================================================== --- a/drivers/video/fbdev/amifb.c +++ b/drivers/video/fbdev/amifb.c @@ -575,6 +575,12 @@ static u_short maxfmode, chipset; #define downx(x, v) ((v) & -(x)) #define modx(x, v) ((v) & ((x) - 1)) +/* + * FIXME: Use C variants of the code marked with #ifdef __mc68000__ + * in the driver. It shouldn't negatively affect the performance and + * is required for APUS support (once it is re-added to the kernel). + * Needs to be tested on the hardware though.. + */ /* if x1 is not a constant, this macro won't make real sense :-) */ #ifdef __mc68000__ #define DIVUL(x1, x2) ({int res; asm("divul %1,%2,%3": "=d" (res): \
Powered by blists - more mailing lists