linux-kernel - Re: [PATCH v4 1/5] regulator: Allow regulators to verify enabled during enable()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO_48GHdhafjgLH1-3upZPXhNjKSt_bPAnPpjA+nhR2wrLbcZw@mail.gmail.com>
Date:   Tue, 2 Jun 2020 17:27:19 +0530
From:   Sumit Semwal <sumit.semwal@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     agross@...nel.org, Bjorn Andersson <bjorn.andersson@...aro.org>,
        lgirdwood@...il.com, robh+dt@...nel.org,
        Nisha Kumari <nishakumari@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org, kgunda@...eaurora.org,
        Rajendra Nayak <rnayak@...eaurora.org>
Subject: Re: [PATCH v4 1/5] regulator: Allow regulators to verify enabled
 during enable()

Hi Mark,

Thanks for the review!

On Tue, 2 Jun 2020 at 16:54, Mark Brown <broonie@...nel.org> wrote:
>
> On Tue, Jun 02, 2020 at 03:39:20PM +0530, Sumit Semwal wrote:
>
> > +
> > +             if (time_remaining <= 0) {
> > +                     rdev_err(rdev, "Enabled check failed.\n");
> > +                     return -ETIMEDOUT;
>
> s/failed/timed out/
Ack
>
> > + * @poll_enabled_time: Maximum time (in uS) to poll if the regulator is
> > + *                          actually enabled, after enable() call
> > + *
>
> This comment needs updating to reflect the new implementation.
Yes, I will update.

Best,
Sumit.