linux-kernel - Re: [PATCH] ALSA: core: Fix control device release issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2d17a48f-f633-4704-f0d9-ce3b668ccc9c@web.de>
Date:   Tue, 2 Jun 2020 14:24:27 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     zhucancan@...o.com, alsa-devel@...a-project.org, kernel@...o.com
Cc:     linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Wang Wenhu <wenhu.wang@...o.com>
Subject: Re: [PATCH] ALSA: core: Fix control device release issue

> We use snd_pcm_add_usr_ctls() in component's .pcm_new(),
> unfortunately snd_soc_dapm_add_routes() meets error during
> adding card->dapm_routes/of_dapm_routes, it will goto probe_end
> to call soc_cleanup_card_resources().
>
> The commit dc82e52492f6 ("ALSA: core: Assure control device
> to be registered at last") will make pcm device release is
> prior to control device release, but the control device needs
> to use pcm pointor, which is already freed by pcm device release.

I suggest to improve this change description.

Regards,
Markus