linux-kernel - Re: [PATCH 07/15] drm/amdgpu: use PCI_IRQ_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfe5dQkOiFoAZx5b-NS1afiD-YC_w+5LcX8P1Hm0ASenA@mail.gmail.com>
Date:   Tue, 2 Jun 2020 17:00:20 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Ruhl, Michael J" <michael.j.ruhl@...el.com>
Cc:     "Stankiewicz, Piotr" <piotr.stankiewicz@...el.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Zhou <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 07/15] drm/amdgpu: use PCI_IRQ_MSI_TYPES where appropriate

On Tue, Jun 2, 2020 at 4:38 PM Ruhl, Michael J <michael.j.ruhl@...el.com> wrote:
> >-----Original Message-----
> >From: dri-devel <dri-devel-bounces@...ts.freedesktop.org> On Behalf Of
> >Piotr Stankiewicz
> >Sent: Tuesday, June 2, 2020 5:21 AM
> >To: Alex Deucher <alexander.deucher@....com>; Christian König
> ><christian.koenig@....com>; David Zhou <David1.Zhou@....com>; David
> >Airlie <airlied@...ux.ie>; Daniel Vetter <daniel@...ll.ch>
> >Cc: Stankiewicz, Piotr <piotr.stankiewicz@...el.com>; dri-
> >devel@...ts.freedesktop.org; amd-gfx@...ts.freedesktop.org; linux-
> >kernel@...r.kernel.org
> >Subject: [PATCH 07/15] drm/amdgpu: use PCI_IRQ_MSI_TYPES where
> >appropriate

...

> >               int nvec = pci_msix_vec_count(adev->pdev);
> >               unsigned int flags;
> >
> >-              if (nvec <= 0) {
> >+              if (nvec > 0)
> >+                      flags = PCI_IRQ_MSI_TYPES;
> >+              else
> >                       flags = PCI_IRQ_MSI;
> >-              } else {
> >-                      flags = PCI_IRQ_MSI | PCI_IRQ_MSIX;
> >-              }
>
> Minor nit:
>
> Is it really necessary to set do this check?  Can flags just
> be set?
>
> I.e.:
>         flags = PCI_IRQ_MSI_TYPES;
>
> pci_alloc_irq_vector() tries stuff in order.  If MSIX is not available,
> it will try MSI.

That's also what I proposed earlier. But I suggested as well to wait
for AMD people to confirm that neither pci_msix_vec_count() nor flags
is needed and we can directly supply MSI_TYPES to the below call.

> >               /* we only need one vector */
> >               nvec = pci_alloc_irq_vectors(adev->pdev, 1, 1, flags);

-- 
With Best Regards,
Andy Shevchenko