linux-kernel - Re: [PATCH -next] PCI: uniphier: Fix Kconfig warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200602143812.GA26880@e121166-lin.cambridge.arm.com>
Date:   Tue, 2 Jun 2020 15:38:12 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     robh@...nel.org, bhelgaas@...gle.com,
        hayashi.kunihiko@...ionext.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] PCI: uniphier: Fix Kconfig warning

On Tue, Jun 02, 2020 at 09:10:33PM +0800, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for PCIE_DW_EP
>   Depends on [n]: PCI [=y] && PCI_ENDPOINT [=n]
>   Selected by [y]:
>   - PCIE_UNIPHIER_EP [=y] && PCI [=y] && (ARCH_UNIPHIER || COMPILE_TEST [=y]) && OF [=y] && HAS_IOMEM [=y]
> 
> Add missing dependency to fix this.
> 
> Fixes: 006564dee825 ("PCI: uniphier: Add Socionext UniPhier Pro5 PCIe endpoint controller driver")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/pci/controller/dwc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Squashed in the commit it is fixing, thanks !

Lorenzo

> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 43a29f7a4501..044a3761c44f 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -293,6 +293,7 @@ config PCIE_UNIPHIER_EP
>  	bool "Socionext UniPhier PCIe endpoint controllers"
>  	depends on ARCH_UNIPHIER || COMPILE_TEST
>  	depends on OF && HAS_IOMEM
> +	depends on PCI_ENDPOINT
>  	select PCIE_DW_EP
>  	help
>  	  Say Y here if you want PCIe endpoint controller support on
> -- 
> 2.17.1
> 
>