linux-kernel - Re: spi: spi-ti-qspi: call pm_runtime_put on pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc8e1397-c605-d73e-363e-9d2ddfb9ae16@web.de>
Date:   Tue, 2 Jun 2020 17:05:18 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Mark Brown <broonie@...nel.org>,
        Navid Emamdoost <navid.emamdoost@...il.com>,
        linux-spi@...r.kernel.org
Cc:     Navid Emamdoost <emamd001@....edu>, Kangjie Lu <kjlu@....edu>,
        Stephen McCamant <smccaman@....edu>,
        Qiushi Wu <wu000273@....edu>,
        Dinghao Liu <dinghao.liu@....edu.cn>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure

>> I find this commit message improvable also according to Linux software
>> development documentation.
>
> Causing people to send out new versions of things for tweaks to the
> commit log consumes time for them and everyone they're sending changes to.

Improving patches (besides source code adjustments) is an usual software
development activity, isn't it?


> Pushing people to make trivial rewordings of their commit logs to
> match your particular taste is not a good use of people's time.

Corresponding tweaks can be combined with recommended tags.
It can be that only “trivial” items were left over for another bit
of fine-tuning. Subsequent description variants can reduce
the probability for additional patch review iterations, can't they?

Regards,
Markus