linux-kernel - Re: [PATCH 08/15] IB/qib: Use PCI_IRQ_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf6xzuD2MPLr2xW0=1-040uNS-Ady1LSZ-9hqGPjK6sxg@mail.gmail.com>
Date:   Tue, 2 Jun 2020 18:35:46 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Piotr Stankiewicz <piotr.stankiewicz@...el.com>
Cc:     Dennis Dalessandro <dennis.dalessandro@...el.com>,
        Mike Marciniszyn <mike.marciniszyn@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "open list:HFI1 DRIVER" <linux-rdma@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate

On Tue, Jun 2, 2020 at 12:25 PM Piotr Stankiewicz
<piotr.stankiewicz@...el.com> wrote:
>
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.

...

> -       unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI;
> +       unsigned int flags = PCI_IRQ_MSI_TYPES;
>
>         if (!pci_is_pcie(dd->pcidev)) {
>                 qib_dev_err(dd, "Can't find PCI Express capability!\n");

Internally I have proposed at last this:

convert the following
        if (dd->flags & QIB_HAS_INTX)
               flags |= PCI_IRQ_LEGACY;

to
        if (dd->flags & QIB_HAS_INTX)
               flags = PCI_IRQ_ALL_TYPES;
        if (dd->flags & QIB_HAS_INTX)
               flags = PCI_IRQ_MSI_TYPES;

-- 
With Best Regards,
Andy Shevchenko