linux-kernel - Re: [PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXtsvewiN3bmfJqwuURN--aCkaR7N6zfYWf82KmFUZnLQ@mail.gmail.com>
Date:   Tue, 2 Jun 2020 11:04:55 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()

On Mon, Jun 1, 2020 at 11:47 PM YueHaibing <yuehaibing@...wei.com> wrote:
> @@ -630,6 +625,9 @@ static int genl_family_rcv_msg_dumpit(const struct genl_family *family,
>                 err = __netlink_dump_start(net->genl_sock, skb, nlh, &c);
>         }
>
> +       genl_family_rcv_msg_attrs_free(info->family, info->attrs, true);
> +       genl_dumpit_info_free(info);
> +
>         return err;
>  }

I do not think you can just move it after __netlink_dump_start(),
because cb->done() can be called, for example, in netlink_sock_destruct()
too.