linux-kernel - Re: [git pull] misc uaccess stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200603205332.GC23230@ZenIV.linux.org.uk>
Date:   Wed, 3 Jun 2020 21:53:32 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [git pull] misc uaccess stuff

On Wed, Jun 03, 2020 at 01:44:39PM -0700, Nathan Chancellor wrote:
> > ----------------------------------------------------------------
> > Al Viro (9):
> >       pselect6() and friends: take handling the combined 6th/7th args into helper
> >       binfmt_elf: don't bother with __{put,copy_to}_user()
> >       binfmt_elf_fdpic: don't use __... uaccess primitives
> 
> This patch breaks arm32:
> 
> $ make -sj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- allyesconfig fs/binfmt_elf_fdpic.o
> ...
> In file included from ./include/linux/sched/task.h:11,
>                  from ./include/linux/sched/signal.h:9,
>                  from ./include/linux/rcuwait.h:6,
>                  from ./include/linux/percpu-rwsem.h:7,
>                  from ./include/linux/fs.h:34,
>                  from fs/binfmt_elf_fdpic.c:11:
> ./include/linux/uaccess.h:149:1: note: declared here
>   149 | copy_to_user(void __user *to, const void *from, unsigned long n)
>       | ^~~~~~~~~~~~
> fs/binfmt_elf_fdpic.c:612:7: error: too few arguments to function 'copy_to_user'
>   612 |   if (copy_to_user(ent + nr, &v))    \
>       |       ^~~~~~~~~~~~
> fs/binfmt_elf_fdpic.c:659:2: note: in expansion of macro 'NEW_AUX_ENT'
>   659 |  NEW_AUX_ENT(AT_EXECFN, bprm->exec);
>       |  ^~~~~~~~~~~

Linus, consider that pull request withdrawn for now, please.  My apologies -
I'll push a fixed variant and resend after a week of having it sit in -next.