linux-kernel - Re: [PATCH] mm: thp: Add new kernel parameters transparent_hugepage_defrag/khugepaged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+eFSM0V6nCHvwy3d5kehA4HpcP7x1zR_C95PnMFGYp9JV36ow@mail.gmail.com>
Date:   Thu, 4 Jun 2020 06:09:31 +0800
From:   Gavin Guo <gavin.guo@...onical.com>
To:     David Rientjes <rientjes@...gle.com>
Cc:     Vlastimil Babka <vbabka@...e.cz>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        Kees Cook <keescook@...omium.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Christian Brauner <christian.brauner@...ntu.com>
Subject: Re: [PATCH] mm: thp: Add new kernel parameters transparent_hugepage_defrag/khugepaged_defrag

On Thu, Jun 4, 2020 at 3:27 AM David Rientjes <rientjes@...gle.com> wrote:
>
> On Wed, 3 Jun 2020, Vlastimil Babka wrote:
>
> > > There is no way to set up the defrag options in boot time. And it's
> > > useful to set it up by default instead of making it work by a
> > > systemd/upstart service or put the command to set up defrag inside
> > > /etc/rc.local.
> > >
> > > Signed-off-by: Gavin Guo <gavin.guo@...onical.com>
> >
> > Well, maybe isntead of adding these handlers, we could extend the new boot
> > parameter sysctl support (handling procfs /proc/sys/) to sysfs (/sys) as well,
> > as Eric already suggested? [1]
> >
> > [1] https://lore.kernel.org/linux-api/87bloj2skm.fsf@x220.int.ebiederm.org/
> >
>
> Fully agreed, I think the solution needs to be more generic since thp
> defrag isn't special here.  With the generic support to tune sysctls and
> sysfs tunables from the command line it seems like this patch would be
> redundant.

Agreed, I'll try to investigate more on how to do that in a generic way.