linux-kernel - Re: [PATCH v4] EDAC/ghes: Setup DIMM label from DMI and use it in error reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200603065657.zrxer5jtgryqlznt@rric.localdomain>
Date:   Wed, 3 Jun 2020 08:56:58 +0200
From:   Robert Richter <rrichter@...vell.com>
To:     Borislav Petkov <bp@...en8.de>
CC:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Aristeu Rozanski <aris@...hat.com>,
        Matthias Brugger <mbrugger@...e.com>,
        <linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] EDAC/ghes: Setup DIMM label from DMI and use it in
 error reports

On 02.06.20 17:48:43, Borislav Petkov wrote:
> On Thu, May 28, 2020 at 12:13:06PM +0200, Robert Richter wrote:

> > v4:
> > 
> >  * dimm->label: Only update dimm->label in if bank/device is found in
> >    the SMBIOS table, this keeps current behavior for machines that do
> >    not provide this information.
> > 
> >  * e->location: Keep current behavior how e->location is written.
> > 
> >  * e->label: Use dimm->label if a DIMM was found by its handle and
> >    "unknown memory" otherwise. This aligns with the edac_mc
> >    implementation.
> > 
> > Signed-off-by: Robert Richter <rrichter@...vell.com>
> > ---
> >  drivers/edac/ghes_edac.c | 37 ++++++++++++++++++++++++++-----------
> >  1 file changed, 26 insertions(+), 11 deletions(-)
> 
> Yap, looks good. I'll queue it after the merge window.

Great, thanks.

-Robert