linux-kernel - Re: [PATCH] media: marvell-ccic: Add missed v4l2_async_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200603124143.GF16711@paasikivi.fi.intel.com>
Date:   Wed, 3 Jun 2020 15:41:43 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Jonathan Corbet <corbet@....net>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Lubomir Rintel <lkundrak@...sk>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: marvell-ccic: Add missed
 v4l2_async_notifier_cleanup()

Hi Chuhong,

Thanks for the patch.

On Wed, Jun 03, 2020 at 07:56:05PM +0800, Chuhong Yuan wrote:
> mccic_register() forgets to cleanup the notifier in its error handler.
> Add the missed call to fix it.
> 
> Fixes: 3eefe36cc00c ("media: marvell-ccic: use async notifier to get the sensor")
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> ---
>  drivers/media/platform/marvell-ccic/mcam-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
> index 09775b6624c6..cf2a0119e679 100644
> --- a/drivers/media/platform/marvell-ccic/mcam-core.c
> +++ b/drivers/media/platform/marvell-ccic/mcam-core.c
> @@ -1940,6 +1940,7 @@ int mccic_register(struct mcam_camera *cam)
>  out:
>  	v4l2_async_notifier_unregister(&cam->notifier);
>  	v4l2_device_unregister(&cam->v4l2_dev);
> +	v4l2_async_notifier_cleanup(&cam->notifier);
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(mccic_register);

The same issue appears to be present in the mcam_shutdown(), could you fix
that one as well?

-- 
Regards,

Sakari Ailus