[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200603132915.GA1584791@kroah.com>
Date: Wed, 3 Jun 2020 15:29:15 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Rajat Jain <rajatja@...gle.com>
Cc: Rajat Jain <rajatxjain@...il.com>,
Bjorn Helgaas <helgaas@...nel.org>,
"Raj, Ashok" <ashok.raj@...el.com>,
"Krishnakumar, Lalithambika" <lalithambika.krishnakumar@...el.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
linux-pci <linux-pci@...r.kernel.org>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Jean-Philippe Brucker <jean-philippe@...aro.org>,
Prashant Malani <pmalani@...gle.com>,
Benson Leung <bleung@...gle.com>,
Todd Broch <tbroch@...gle.com>,
Alex Levin <levinale@...gle.com>,
Mattias Nissler <mnissler@...gle.com>,
Zubin Mithra <zsm@...gle.com>,
Bernie Keany <bernie.keany@...el.com>,
Aaron Durbin <adurbin@...gle.com>,
Diego Rivas <diegorivas@...gle.com>,
Duncan Laurie <dlaurie@...gle.com>,
Furquan Shaikh <furquan@...gle.com>,
Jesse Barnes <jsbarnes@...gle.com>,
Christian Kellner <christian@...lner.me>,
Alex Williamson <alex.williamson@...hat.com>,
Joerg Roedel <joro@...tes.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] Restrict the untrusted devices, to bind to only a set of
"whitelisted" drivers
On Wed, Jun 03, 2020 at 05:57:02AM -0700, Rajat Jain wrote:
> > So please, in summary:
> > - don't think this is some new type of thing, it's an old issue
> > transferred to yet-another-hardware-bus. Not to say this is
> > not important, just please look at the work that others have
> > done in the past to help mitigate and solve this (reading the
> > Wireless USB spec should help you out here too, as they
> > detailed all of this.)
> > - do copy what USB did, by moving that logic into the driver
> > core so that all busses who want to take advantage of this
> > type of functionality, easily can do so.
>
> Understood, will keep that in mind. I may first present a "PCI
> subsystem only" draft just to get a feel for it, since that is more
> familiar to me and also already has some bits and pieces we need for
> this.
Why? Do it right the first time. To waste reviewer's time on something
that you know you have to throw away and do it "correctly" again, is not
very nice. I know I would put you on the bottom of my "patches to
review" list if you did that to me :)
thanks,
greg k-h
Powered by blists - more mailing lists