[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200603141218.131663-1-colin.king@canonical.com>
Date: Wed, 3 Jun 2020 15:12:18 +0100
From: Colin King <colin.king@...onical.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Tai-hwa Liang <avatar@...telic.com>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org
Subject: [PATCH] input: sentelic: fix error return when fsp_reg_write fails
From: Colin Ian King <colin.king@...onical.com>
Currently when the call to fsp_reg_write fails -EIO is not being returned
because the count is being returned instead of the return value in retval.
Fix this by returning the value in retval instead of count.
Addresses-Coverity: ("Unused value")
Fixes: fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
drivers/input/mouse/sentelic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/sentelic.c b/drivers/input/mouse/sentelic.c
index e99d9bf1a267..e78c4c7eda34 100644
--- a/drivers/input/mouse/sentelic.c
+++ b/drivers/input/mouse/sentelic.c
@@ -441,7 +441,7 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
fsp_reg_write_enable(psmouse, false);
- return count;
+ return retval;
}
PSMOUSE_DEFINE_WO_ATTR(setreg, S_IWUSR, NULL, fsp_attr_set_setreg);
--
2.25.1
Powered by blists - more mailing lists