linux-kernel - Re: [PATCH] scsi: Fix reference count leak in iscsi_boot_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159114947917.26776.6215710664403797046.b4-ty@oracle.com>
Date:   Tue,  2 Jun 2020 22:31:38 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     kjlu@....edu, "wu000273@....edu" <wu000273@....edu>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Lee Duncan <lduncan@...e.com>, open-iscsi@...glegroups.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org, Chris Leech <cleech@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: Fix reference count leak in iscsi_boot_create_kobj.

On Thu, 28 May 2020 15:13:53 -0500, wu000273@....edu wrote:

> kobject_init_and_add() should be handled when it return an error,
> because kobject_init_and_add() takes reference even when it fails.
> If this function returns an error, kobject_put() must be called to
> properly clean up the memory associated with the object. Previous
> commit "b8eb718348b8" fixed a similar problem. Thus replace calling
> kfree() by calling kobject_put().

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: iscsi: Fix reference count leak in iscsi_boot_create_kobj
      https://git.kernel.org/mkp/scsi/c/0267ffce562c

-- 
Martin K. Petersen	Oracle Linux Engineering