linux-kernel - Re: [PATCH RFC] panic: Fix deadlock in panic()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <fabff510-bd19-1712-2aa2-b1d742349c39@web.de>
Date:   Wed, 3 Jun 2020 17:30:14 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Cheng Jian <cj.chengjian@...wei.com>,
        kernel-janitors@...r.kernel.org
Cc:     Wang ShaoBo <bobo.shaobowang@...wei.com>,
        Chen Wandun <chenwandun@...wei.com>,
        Li Bin <huawei.libin@...wei.com>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Xie XiuQi <xiexiuqi@...wei.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] panic: Fix deadlock in panic()

>  A deadlock caused by logbuf_lock occurs when panic:

I suggest a few wording adjustments for this change description.

Would you like to omit an extra space character at the beginning of this sentence?


> we try to re-init …

We …


> … deadlock, but it … here, because :

… deadlock. But it … here because:


> Firstly, …

1. …


> When the CPU bring down …, … CPU willn't

… CPU was brought down …, … CPU will not


> Secondly, …

2. …


> … callback, so if printk() …

… callback. If printk() …


> …, deadlock will still occurs. Eg, …

…, deadlock will still occur. E. g. …


Regards,
Markus