linux-kernel - Re: [PATCH] clk: clk-st: Add missed return value checks in st_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f0d21bd6-6db7-d643-b662-6ca26efd28ba@web.de>
Date:   Wed, 3 Jun 2020 19:30:46 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Chuhong Yuan <hslester96@...il.com>, linux-clk@...r.kernel.org
Cc:     Akshu Agrawal <Akshu.Agrawal@....com>,
        Daniel Kurtz <djkurtz@...omium.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Stephen Boyd <sboyd@...nel.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: clk-st: Add missed return value checks in
 st_clk_probe()

> st_clk_probe() has not check for clk_hw_register_mux(), clk_hw_register_gate()
> and devm_clk_hw_register_clkdev().
> Add the missed checks and return devm_clk_hw_register_clkdev()'s return value
> to check errors.

How do you think about another wording variant?

   Return values were not checked after calls of the following functions.
   - clk_hw_register_mux
   - clk_hw_register_gate
   - devm_clk_hw_register_clkdev

   * Thus add error detection and the corresponding exception handling.

   * Return the value from the function call “devm_clk_hw_register_clkdev”
     at the end of this function implementation.

Regards,
Markus