linux-kernel - Re: [PATCH] media: budget-core: Improve exception handling in budget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e3633733-8b83-d4ef-3256-e2b1117419f0@web.de>
Date:   Wed, 3 Jun 2020 20:24:27 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Chuhong Yuan <hslester96@...il.com>, linux-media@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] media: budget-core: Improve exception handling in
 budget_register()

> Add the missed undo functions for error handling to fix it.

…
> +++ b/drivers/media/pci/ttpci/budget-core.c
> @@ -369,20 +369,25 @@  static int budget_register(struct budget *budget)
…
>  	return 0;
> +
+err:
> +	dvb_dmxdev_release(&budget->dmxdev);
> +	dvb_dmx_release(&budget->demux);
> +	return ret;
>  }
…

Perhaps use the label “release_dmxdev” instead?

Regards,
Markus