linux-kernel - Re: [PATCH bpf v2] bpf: fix unused-var without NETDEVICES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94837ee2-3dcc-41ef-e932-0c6d1285156d@iogearbox.net>
Date:   Thu, 4 Jun 2020 22:53:37 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Song Liu <song@...nel.org>,
        Matthieu Baerts <matthieu.baerts@...sares.net>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Andrii Nakryiko <andriin@...com>,
        Alexei Starovoitov <ast@...nel.org>, bpf <bpf@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>, fejes@....elte.hu,
        John Fastabend <john.fastabend@...il.com>,
        Martin KaFai Lau <kafai@...com>,
        KP Singh <kpsingh@...omium.org>,
        Jakub Kicinski <kuba@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>
Subject: Re: [PATCH bpf v2] bpf: fix unused-var without NETDEVICES

On 6/3/20 10:45 PM, Song Liu wrote:
> On Wed, Jun 3, 2020 at 12:05 PM Matthieu Baerts
> <matthieu.baerts@...sares.net> wrote:
>>
>> A recent commit added new variables only used if CONFIG_NETDEVICES is
>> set. A simple fix would be to only declare these variables if the same
>> condition is valid but Alexei suggested an even simpler solution:
>>
>>      since CONFIG_NETDEVICES doesn't change anything in .h I think the
>>      best is to remove #ifdef CONFIG_NETDEVICES from net/core/filter.c
>>      and rely on sock_bindtoindex() returning ENOPROTOOPT in the extreme
>>      case of oddly configured kernels.
>>
>> Fixes: 70c58997c1e8 ("bpf: Allow SO_BINDTODEVICE opt in bpf_setsockopt")
>> Suggested-by: Alexei Starovoitov <alexei.starovoitov@...il.com>
>> Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> 
> Acked-by: Song Liu <songliubraving@...com>

Applied, thanks!