linux-kernel - Re: [PATCH v4 1/1] perf: cs-etm: Allow no CoreSight sink to be specified on command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200604212139.GE18961@xps15>
Date:   Thu, 4 Jun 2020 15:21:39 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Mike Leach <mike.leach@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
        linux-kernel@...r.kernel.org, acme@...nel.org,
        suzuki.poulose@....com, peterz@...radead.org, mingo@...hat.com
Subject: Re: [PATCH v4 1/1] perf: cs-etm: Allow no CoreSight sink to be
 specified on command line

On Tue, May 26, 2020 at 11:53:10AM +0100, Mike Leach wrote:
> Adjust the handling of the session sink selection to allow no sink to
> be selected on the command line. This then forwards the sink selection to
> the CoreSight infrastructure which will attempt to select a sink based
> on the default sink select priorities.
> 
> Signed-off-by: Mike Leach <mike.leach@...aro.org>
> ---
>  tools/perf/arch/arm/util/cs-etm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c
> index 941f814820b8..ed9ea2c60f27 100644
> --- a/tools/perf/arch/arm/util/cs-etm.c
> +++ b/tools/perf/arch/arm/util/cs-etm.c
> @@ -242,10 +242,10 @@ static int cs_etm_set_sink_attr(struct perf_pmu *pmu,
>  	}
>  
>  	/*
> -	 * No sink was provided on the command line - for _now_ treat
> -	 * this as an error.
> +	 * No sink was provided on the command line - allow the CoreSight
> +	 * system to look for a default
>  	 */
> -	return ret;
> +	return 0;

Leo added a tested-by for this patch. As I wrote on a previous patch we are
currently in the middle of the merge window and as such this set needs to be
rebased on v5.8-rc1 (when it comes out) and sent again.

Thanks,
Mathieu

>  }
>  
>  static int cs_etm_recording_options(struct auxtrace_record *itr,
> -- 
> 2.17.1
>