linux-kernel - Re: [RFC 3/4] regulator: lp87565: dt: add LP87524-Q1 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Jun 2020 07:01:42 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Luca Ceresoli <luca@...aceresoli.net>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Keerthy <j-keerthy@...com>, Axel Lin <axel.lin@...ics.com>
Subject: Re: [RFC 3/4] regulator: lp87565: dt: add LP87524-Q1 variant

On Wed, 03 Jun 2020, Luca Ceresoli wrote:

> Add the LP87524-Q1 to the lp87565 bindings document along with an example.

Keep the way to describe model numbers consistent.

I suggest LP87565 here (even though the filename is in lower case).

> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
> ---
>  .../devicetree/bindings/mfd/lp87565.txt       | 47 ++++++++++++++++++-

This is an MFD patch.

Please change the patch subject to reflect that.

>  1 file changed, 46 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
> index b75ae23a1ef3..839eac6b75c2 100644
> --- a/Documentation/devicetree/bindings/mfd/lp87565.txt
> +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt
> @@ -1,7 +1,8 @@
>  TI LP87565 PMIC MFD driver
>  
>  Required properties:
> -  - compatible:		one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1"
> +  - compatible:		one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1",
> +			"ti,lp87524-q1"

Maybe have 2 per line.  It would really help with my OCD!

>    - reg:		I2C slave address.
>    - gpio-controller:	Marks the device node as a GPIO Controller.
>    - #gpio-cells:	Should be two.  The first cell is the pin number and
> @@ -64,3 +65,47 @@ lp87561_pmic: pmic@62 {
>  		};
>  	};
>  };
> +
> +Example for the TI LP87524-Q1 PMIC (four 1-phase output configuration):
> +
> +lp87524_pmic: pmic@60 {
> +	compatible = "ti,lp87524-q1";
> +	reg = <0x60>;
> +	gpio-controller;
> +	#gpio-cells = <2>;
> +
> +	buck0-in-supply = <&vdd_5v0>;
> +	buck1-in-supply = <&vdd_5v0>;
> +	buck2-in-supply = <&vdd_5v0>;
> +	buck3-in-supply = <&vdd_5v0>;
> +
> +	regulators {
> +		buck0_reg: buck0 {
> +			regulator-name = "buck0";
> +			regulator-min-microvolt = <3300000>;
> +			regulator-max-microvolt = <3300000>;
> +			regulator-always-on;
> +		};
> +
> +		buck1_reg: buck1 {
> +			regulator-name = "buck1";
> +			regulator-min-microvolt = <1350000>;
> +			regulator-max-microvolt = <1350000>;
> +			regulator-always-on;
> +		};
> +
> +		buck2_reg: buck2 {
> +			regulator-name = "buck2";
> +			regulator-min-microvolt = <950000>;
> +			regulator-max-microvolt = <950000>;
> +			regulator-always-on;
> +		};
> +
> +		buck3_reg: buck3 {
> +			regulator-name = "buck3";
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <1800000>;
> +			regulator-always-on;
> +		};
> +	};
> +};

Patch looks okay, but Rob or Mark must review too.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog