linux-kernel - Re: [PATCH] can: Replace zero-length array with flexible-array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74c08a71-afb5-aba4-2c30-c342b4a7e61f@hartkopp.net>
Date:   Thu, 4 Jun 2020 08:31:55 +0200
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     linux-can@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: Replace zero-length array with flexible-array

Hi Gustavo,

On 04.06.20 02:58, Gustavo A. R. Silva wrote:

> Sorry for the late reply. I totally lost track of this thread. :/

NP. At least your workflow seems to work :o)

> pahole shows exactly the same output either if cf is a zero-length array or
> a flexible-array member:
> 
> $ pahole -C 'can_skb_priv' drivers/net/can/dev.o
> 
> struct can_skb_priv {
> 	int                        ifindex;              /*     0     4 */
> 	int                        skbcnt;               /*     4     4 */
> 	struct can_frame           cf[] __attribute__((__aligned__(8))); /*     8     0 */
> 
> 	/* size: 8, cachelines: 1, members: 3 */
> 	/* forced alignments: 1 */
> 	/* last cacheline: 8 bytes */
> } __attribute__((__aligned__(8)));
> 
> So, it seems everything should fine. :)

Great! Thanks for the info - and how I could have checked it on my own, too.

Best,
Oliver