lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Jun 2020 02:50:27 +0200 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: Kees Cook <keescook@...omium.org> Cc: linux-kernel <linux-kernel@...r.kernel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Alexander Potapenko <glider@...gle.com>, Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>, drbd-dev@...ts.linbit.com, linux-block@...r.kernel.org, b43-dev@...ts.infradead.org, Network Development <netdev@...r.kernel.org>, linux-wireless <linux-wireless@...r.kernel.org>, linux-ide@...r.kernel.org, linux-clk@...r.kernel.org, linux-spi@...r.kernel.org, Linux-MM <linux-mm@...ck.org>, clang-built-linux <clang-built-linux@...glegroups.com> Subject: Re: [PATCH 10/10] compiler: Remove uninitialized_var() macro Hi Kees, On Thu, Jun 4, 2020 at 1:32 AM Kees Cook <keescook@...omium.org> wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > either simply initialize the variable or make compiler changes. > > As recommended[2] by[3] Linus[4], remove the macro. > > [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/ > [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ > [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ > [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ > > Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org> > Signed-off-by: Kees Cook <keescook@...omium.org> > --- +1, one less trick split between `compiler*` files. Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> Cheers, Miguel
Powered by blists - more mailing lists