linux-kernel - Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANN689GvTF75Knsc82PGrwA44J+yx2ORP-i3fp36avMuxRPwdg@mail.gmail.com>
Date:   Thu, 4 Jun 2020 01:38:18 -0700
From:   Michel Lespinasse <walken@...gle.com>
To:     youling 257 <youling257@...il.com>
Cc:     "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Daniel Jordan <daniel.m.jordan@...cle.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Hugh Dickins <hughd@...gle.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Jerome Glisse <jglisse@...hat.com>,
        John Hubbard <jhubbard@...dia.com>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>,
        Peter Zijlstra <peterz@...radead.org>,
        David Rientjes <rientjes@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Matthew Wilcox <willy@...radead.org>,
        Ying Han <yinghan@...gle.com>
Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock

On Thu, Jun 4, 2020 at 1:16 AM youling 257 <youling257@...il.com> wrote:
> 2020-06-04 13:57 GMT+08:00, Michel Lespinasse <walken@...gle.com>:
> > However I would like more information about your report. Did you apply
> > the series yourself ? If so, what base tree did you apply it onto ? If
> > not, what tree did you use that already included the series ?
>
> I build linux next-20200603 tree have the kernel/sys.c error.

Thanks for the info.

The proper fix is to replace down_write(&mm->mmap_sem) with
mmap_write_lock(mm) and up_write(&mm->mmap_sem) with
mmap_write_unlock(mm)

If you just needed a quick fix to get the tree to build, what you did
(replacing mmap_sem with mmap_lock) is also fine.

Thanks again !

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.