linux-kernel - Re: [PATCH 13/13] fs: move binfmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cbba430-a768-72db-bd45-bcbba0376219@huawei.com>
Date:   Thu, 4 Jun 2020 16:45:20 +0800
From:   Xiaoming Ni <nixiaoming@...wei.com>
To:     Luis Chamberlain <mcgrof@...nel.org>, <keescook@...omium.org>,
        <yzaikin@...gle.com>, <ebiederm@...ssion.com>, <axboe@...nel.dk>,
        <clemens@...isch.de>, <arnd@...db.de>,
        <gregkh@...uxfoundation.org>, <jani.nikula@...ux.intel.com>,
        <joonas.lahtinen@...ux.intel.com>, <rodrigo.vivi@...el.com>,
        <airlied@...ux.ie>, <daniel@...ll.ch>, <benh@...nel.crashing.org>,
        <rdna@...com>, <viro@...iv.linux.org.uk>, <mark@...heh.com>,
        <jlbec@...lplan.org>, <joseph.qi@...ux.alibaba.com>,
        <vbabka@...e.cz>, <sfr@...b.auug.org.au>, <jack@...e.cz>,
        <amir73il@...il.com>, <rafael@...nel.org>, <tytso@....edu>
CC:     <julia.lawall@...6.fr>, <akpm@...ux-foundation.org>,
        <intel-gfx@...ts.freedesktop.org>,
        <dri-devel@...ts.freedesktop.org>, <linuxppc-dev@...ts.ozlabs.org>,
        <ocfs2-devel@....oracle.com>, <linux-kernel@...r.kernel.org>,
        <wangle6@...wei.com>, <alex.huangjianhui@...wei.com>,
        <laiyuanyuan.lai@...wei.com>
Subject: Re: [PATCH 13/13] fs: move binfmt_misc sysctl to its own file

On 2020/5/29 15:41, Luis Chamberlain wrote:
> This moves the binfmt_misc sysctl to its own file to help remove
> clutter from kernel/sysctl.c.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
> ---
>   fs/binfmt_misc.c | 1 +
>   kernel/sysctl.c  | 7 -------
>   2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
> index f69a043f562b..656b3f5f3bbf 100644
> --- a/fs/binfmt_misc.c
> +++ b/fs/binfmt_misc.c
> @@ -821,6 +821,7 @@ static int __init init_misc_binfmt(void)
>   	int err = register_filesystem(&bm_fs_type);
>   	if (!err)
>   		insert_binfmt(&misc_format);
> +	register_sysctl_empty_subdir("fs", "binfmt_misc");
>   	return err;
>   }
build error when CONFIG_BINFMT_MISC=m

ERROR: modpost: "register_sysctl_empty_subdir" [fs/binfmt_misc.ko] 
undefined!

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 27f0c9ea..4129dfb 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -2853,6 +2853,7 @@ void register_sysctl_empty_subdir(const char *base,
  {
         register_sysctl_subdir(base, subdir, sysctl_mount_point);
  }
+EXPORT_SYMBOL_GPL(register_sysctl_empty_subdir);
  #endif /* CONFIG_SYSCTL */


Thanks
Xiaoming Ni