linux-kernel - Re: [PATCH v2] media: omap3isp: Add missed v4l2_ctrl_handler_free() for preview_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200604095026.GI9947@valkosipuli.retiisi.org.uk>
Date:   Thu, 4 Jun 2020 12:50:26 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Chuhong Yuan <hslester96@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Ilkka Myllyperkio <ilkka.myllyperkio@...ica.fi>,
        "Ivan T . Ivanov" <iivanov@...sol.com>,
        Vimarsh Zutshi <vimarsh.zutshi@...il.com>,
        Stanimir Varbanov <svarbanov@...sol.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: omap3isp: Add missed v4l2_ctrl_handler_free()
 for preview_init_entities()

On Thu, Jun 04, 2020 at 12:33:21PM +0300, Laurent Pinchart wrote:
> Hi Chuhong,
> 
> (CC'ing Sakari Ailus)
> 
> Thank you for the patch.
> 
> On Thu, Jun 04, 2020 at 12:41:22AM +0800, Chuhong Yuan wrote:
> > preview_init_entities() does not call v4l2_ctrl_handler_free() when
> > it fails.
> > Add the missed function to fix it.
> > 
> > Fixes: de1135d44f4f ("[media] omap3isp: CCDC, preview engine and resizer]")
> 
> There's an extra ']' at the end. Apart from that,
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> Sakari, could you take this patch ?

Done; thank you!

-- 
Sakari Ailus