linux-kernel - Re: [PATCH v4 0/9] remoteproc: Add support for attaching with rproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0780724c-4fc0-9f98-023e-aa1245b01888@st.com>
Date:   Thu, 4 Jun 2020 16:24:01 +0200
From:   Arnaud POULIQUEN <arnaud.pouliquen@...com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "ohad@...ery.com" <ohad@...ery.com>
CC:     "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Loic PALLARDY <loic.pallardy@...com>,
        "s-anna@...com" <s-anna@...com>
Subject: Re: [PATCH v4 0/9] remoteproc: Add support for attaching with rproc

Hi Mathieu,

On 6/1/20 7:51 PM, Mathieu Poirier wrote:
> This fourth iteration implements a solution that is fairly different from
> what was proposed in V3 and earlier versions.  Three aspects have been 
> revisited:
> 
> 1) Only the scenario where the remoteproc core is attaching to the remote
>    processor is implemented.  Other scenarios where actions need to be 
>    taken when the remote processor is stopped or crashes will be
>    considered in subsequent versions.
> 
> 2) The introduction of a new RPROC_DETACHED state to be set by platform
>    drivers when needing to attach to an already running remote processor.
> 
> 3) New functions are introduced to replicate the functionality provided by
>    rproc_fw_boot() and rproc_start(), minus operations related to firmware
>    management. 
> 
> Enhancement to the documentation has been left out intentionally until it
> is agreed to move forward with this implementation.

Look good to me, i have only a minor concerns about the code duplication
introduced by the point 3)

If you are agree with that, I plan to do a new review on the stm32 series
when you will start the documentation :-)

Regards,
Arnaud

> 
> Applies cleanly on rproc-next(7dcef3988eed) and will be rebased on v5.8-rc1
> when it comes out in two weeks.
> 
> Thanks,
> Mathieu
> 
> Mathieu Poirier (9):
>   remoteproc: Add new RPROC_DETACHED state
>   remoteproc: Add new attach() remoteproc operation
>   remoteproc: Introducing function rproc_attach()
>   remoteproc: Introducing function rproc_actuate()
>   remoteproc: Introducing function rproc_validate()
>   remoteproc: Refactor function rproc_boot()
>   remoteproc: Refactor function rproc_trigger_auto_boot()
>   remoteproc: Refactor function rproc_free_vring()
>   remoteproc: Properly handle firmware name when attaching
> 
>  drivers/remoteproc/remoteproc_core.c     | 226 +++++++++++++++++++++--
>  drivers/remoteproc/remoteproc_internal.h |   8 +
>  drivers/remoteproc/remoteproc_sysfs.c    |  17 +-
>  include/linux/remoteproc.h               |   9 +-
>  4 files changed, 243 insertions(+), 17 deletions(-)
>