linux-kernel - Re: [PATCH] mm/memory_hotplug: fix default_zone_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a54dd678-8970-3122-e93b-0e99e35a0dc8@redhat.com>
Date:   Thu, 4 Jun 2020 16:49:24 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@...il.com>,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Michal Hocko <mhocko@...nel.org>, Baoquan He <bhe@...hat.com>
Subject: Re: [PATCH] mm/memory_hotplug: fix default_zone_for_pfn() to include
 highmem zone range

On 04.06.20 15:39, Vamshi K Sthambamkadi wrote:
> On x86_32, while onlining highmem sections, the func default_zone_for_pfn()
> defaults target zone to ZONE_NORMAL (movable_node_enabled = 0). Onlining of
> pages is successful, and these highmem pages are moved into zone_normal.
> 
> As a consequence, these pages are treated as low mem, and page addresses
> are calculated using lowmem_page_address() which effectively overflows the
> 32 bit virtual addresses, leading to kernel panics and system becomes
> unusable.
> 
> Change default_kernel_zone_for_pfn() to intersect highmem pfn range, and
> calculate the default zone accordingly.

We discussed this recently [1], and decided that we don't really care
about memory hotplug on 32-bit anymore (especially, user space could
still configure a different zone and make things crash). There was a
patch from Michal in [1], looks like it has not been picked up yet.

@Andrew, can we queue Michals patch?

[1] https://lkml.kernel.org/r/20200218100532.GA4151@dhcp22.suse.cz

> 
> Signed-off-by: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@...il.com>
> ---
>  mm/memory_hotplug.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index c4d5c45..30f101a 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -725,8 +725,13 @@ static struct zone *default_kernel_zone_for_pfn(int nid, unsigned long start_pfn
>  {
>  	struct pglist_data *pgdat = NODE_DATA(nid);
>  	int zid;
> +	int nr_zones = ZONE_NORMAL;
>  
> -	for (zid = 0; zid <= ZONE_NORMAL; zid++) {
> +#ifdef CONFIG_HIGHMEM
> +	nr_zones = ZONE_HIGHMEM;
> +#endif
> +
> +	for (zid = 0; zid <= nr_zones; zid++) {
>  		struct zone *zone = &pgdat->node_zones[zid];
>  
>  		if (zone_intersects(zone, start_pfn, nr_pages))
> 


-- 
Thanks,

David / dhildenb