linux-kernel - Re: [PATCH] pinctrl: tegra: Use noirq suspend/resume callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70a740d5-05b2-b8a6-fea6-da192f9411f3@gmail.com>
Date:   Thu, 4 Jun 2020 21:00:06 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Vidya Sagar <vidyas@...dia.com>, linus.walleij@...aro.org,
        treding@...dia.com, jonathanh@...dia.com, skomatineni@...dia.com
Cc:     linux-gpio@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, kthota@...dia.com,
        mmaddireddy@...dia.com, sagar.tv@...il.com
Subject: Re: [PATCH] pinctrl: tegra: Use noirq suspend/resume callbacks

04.06.2020 20:49, Vidya Sagar пишет:
> Use noirq suspend/resume callbacks as other drivers which implement
> noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to
> configure the signals used by their respective devices in the noirq phase.
> 
> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
> ---
>  drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index 21661f6490d6..195cfe557511 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -731,8 +731,8 @@ static int tegra_pinctrl_resume(struct device *dev)
>  }
>  
>  const struct dev_pm_ops tegra_pinctrl_pm = {
> -	.suspend = &tegra_pinctrl_suspend,
> -	.resume = &tegra_pinctrl_resume
> +	.suspend_noirq = &tegra_pinctrl_suspend,
> +	.resume_noirq = &tegra_pinctrl_resume
>  };
>  
>  static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx)
> 

That's a good catch! Perhaps I2C on later Tegra SoCs also should suffer
similarly to the PCIe.

Reviewed-by: Dmitry Osipenko <digetx@...il.com>