linux-kernel - Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3444be6-28e6-bef5-08cf-6038620f65c6@web.de>
Date:   Thu, 4 Jun 2020 20:24:34 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Venkata Lakshmi Narayana Gubba <gubbaven@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-bluetooth@...r.kernel.org
Cc:     Balakrishna Godavarthi <bgodavar@...eaurora.org>,
        hemantg@...eaurora.org, Johan Hedberg <johan.hedberg@...il.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rocky Liao <rjliao@...eaurora.org>,
        Rob Herring <robh@...nel.org>,
        Sean Paul <seanpaul@...omium.org>,
        Claire Chang <tientzu@...omium.org>, yshavit@...gle.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout

> Due to race conditions between qca_hw_error and qca_controller_memdump
> during SSR timeout,the same pointer is freed twice.

This is an unfortunate software situation.


> Which results to double free error.

How do you think about to omit this sentence from the change description?


> Now a lock is acquired while SSR state moved to timeout.

I suggest to convert this information into an imperative wording.

Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus