linux-kernel - Re: [PATCH 4.19 12/80] pppoe: only process PADT targeted at local interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPJ9Yc8YOeqeO4mo80iVMf3ay+CkdMvYzJY1BqXMNPcKzL6_zg@mail.gmail.com>
Date:   Thu, 4 Jun 2020 20:39:00 +0200
From:   David Balažic <xerces9@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Guillaume Nault <gnault@...hat.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 4.19 12/80] pppoe: only process PADT targeted at local interfaces

Hi!

Is there a good reason this did not land in 4.14 branch?

Openwrt is using that and so it missed this patch.

Any chance it goes in in next round?

Regards,
David

On Mon, 18 May 2020 at 19:50, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> From: Guillaume Nault <gnault@...hat.com>
>
> [ Upstream commit b8c158395119be62294da73646a3953c29ac974b ]
>
> We don't want to disconnect a session because of a stray PADT arriving
> while the interface is in promiscuous mode.
> Furthermore, multicast and broadcast packets make no sense here, so
> only PACKET_HOST is accepted.
>
> Reported-by: David Balažic <xerces9@...il.com>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Guillaume Nault <gnault@...hat.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/net/ppp/pppoe.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> --- a/drivers/net/ppp/pppoe.c
> +++ b/drivers/net/ppp/pppoe.c
> @@ -497,6 +497,9 @@ static int pppoe_disc_rcv(struct sk_buff
>         if (!skb)
>                 goto out;
>
> +       if (skb->pkt_type != PACKET_HOST)
> +               goto abort;
> +
>         if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr)))
>                 goto abort;
>
>
>