linux-kernel - unable to compile after "module: Make module_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxRZqwxxvxo_JhtDVX7ke09tVDOW-d6dz4bw1OVhHETnrE+mQ@mail.gmail.com>
Date:   Fri, 5 Jun 2020 13:21:49 +0300
From:   Anatoly Pugachev <matorola@...il.com>
To:     Linux Kernel list <linux-kernel@...r.kernel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Jessica Yu <jeyu@...nel.org>, Jiri Kosina <jkosina@...e.cz>
Subject: unable to compile after "module: Make module_enable_ro() static again"

Hello!

i'm unable to compile kernel on debian sid/unstable (tested on sparc64
and ppc64) after commit e6eff4376e2897c2e14b70d87bf7284cdb093830

~/linux-2.6$ git bisect bad
e6eff4376e2897c2e14b70d87bf7284cdb093830 is the first bad commit
commit e6eff4376e2897c2e14b70d87bf7284cdb093830
Author: Josh Poimboeuf <jpoimboe@...hat.com>
Date:   Wed Apr 29 10:24:53 2020 -0500

    module: Make module_enable_ro() static again

    Now that module_enable_ro() has no more external users, make it static
    again.

    Suggested-by: Jessica Yu <jeyu@...nel.org>
    Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
    Acked-by: Jessica Yu <jeyu@...nel.org>
    Signed-off-by: Jiri Kosina <jkosina@...e.cz>

 include/linux/module.h | 6 ------
 kernel/module.c        | 3 ++-
 2 files changed, 2 insertions(+), 7 deletions(-)


git bisect log :

~/linux-2.6$ git bisect log
git bisect start
# bad: [435faf5c218a47fd6258187f62d9bb1009717896] Merge tag
'riscv-for-linus-5.8-mw0' of
git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux
git bisect bad 435faf5c218a47fd6258187f62d9bb1009717896
# good: [6929f71e46bdddbf1c4d67c2728648176c67c555] atomisp: avoid
warning about unused function
git bisect good 6929f71e46bdddbf1c4d67c2728648176c67c555
# bad: [694b5a5d313f3997764b67d52bab66ec7e59e714] Merge tag
'arm-soc-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
git bisect bad 694b5a5d313f3997764b67d52bab66ec7e59e714
# good: [d9b8fbf15d05350b36081eddafcf7b15aa1add50] ALSA: es1688: Add
the missed snd_card_free()
git bisect good d9b8fbf15d05350b36081eddafcf7b15aa1add50
# bad: [9ff7258575d5fee011649d20cc56de720a395191] Merge branch
'proc-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
git bisect bad 9ff7258575d5fee011649d20cc56de720a395191
# good: [acf25aa66371359f542d14e8d993b530fe25d7ac] Merge tag
'Smack-for-5.8' of git://github.com/cschaufler/smack-next
git bisect good acf25aa66371359f542d14e8d993b530fe25d7ac
# good: [86c67ce20d080bdfefafd461d3068cad0a49a66b] Merge tag
'leds-5.8-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds
git bisect good 86c67ce20d080bdfefafd461d3068cad0a49a66b
# bad: [9fb4c5250f10dc4d8257cd766991be690eb25c5b] Merge branch
'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching
git bisect bad 9fb4c5250f10dc4d8257cd766991be690eb25c5b
# good: [16ba7e312045cd5d32fba0156312b4303f200787] Merge branches
'for-5.7/upstream-fixes', 'for-5.8/apple', 'for-5.8/asus',
'for-5.8/core', 'for-5.8/intel-ish', 'for-5.8/logitech',
'for-5.8/mcp2221' and 'for-5.8/multitouch' into for-linus
git bisect good 16ba7e312045cd5d32fba0156312b4303f200787
# good: [5b384f933590a086ca9a0abdc2e55e41107ac440] x86/module: Use
text_mutex in apply_relocate_add()
git bisect good 5b384f933590a086ca9a0abdc2e55e41107ac440
# bad: [f55d9895884b1e816f95b5109b4b3827ae18c4ab] MAINTAINERS: add
lib/livepatch to LIVE PATCHING
git bisect bad f55d9895884b1e816f95b5109b4b3827ae18c4ab
# bad: [2a4248749624a38ebddcd1fd82bbab8132d655ad] MAINTAINERS: adjust
to livepatch .klp.arch removal
git bisect bad 2a4248749624a38ebddcd1fd82bbab8132d655ad
# bad: [e6eff4376e2897c2e14b70d87bf7284cdb093830] module: Make
module_enable_ro() static again
git bisect bad e6eff4376e2897c2e14b70d87bf7284cdb093830
# first bad commit: [e6eff4376e2897c2e14b70d87bf7284cdb093830] module:
Make module_enable_ro() static again



error message is :

~/linux-2.6$ make  -j 24
  CALL    scripts/atomic/check-atomics.sh
  CALL    scripts/checksyscalls.sh
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
  CHK     include/generated/compile.h
  CC      kernel/module.o
kernel/module.c: In function ‘do_init_module’:
kernel/module.c:3576:2: error: implicit declaration of function
‘module_enable_ro’; did you mean ‘module_enable_x’?
[-Werror=implicit-function-declaration]
 3576 |  module_enable_ro(mod, true);
      |  ^~~~~~~~~~~~~~~~
      |  module_enable_x
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:266: kernel/module.o] Error 1
make: *** [Makefile:1722: kernel] Error 2


$ gcc --version
gcc (Debian 9.3.0-12) 9.3.0