| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Jun 2020 08:01:23 +0800
From: kernel test robot <lkp@...el.com>
To: Nathan Chancellor <natechancellor@...il.com>
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
linux-kernel@...r.kernel.org,
Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: drivers/gpu/drm/i915/gt/intel_gt_pm.c:23:2: error: format string is
not a string literal (potentially insecure)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 15a2bc4dbb9cfed1c661a657fcb10798150b7598
commit: e2079e93f562c7f7a030eb7642017ee5eabaaa10 kbuild: Do not enable -Wimplicit-fallthrough for clang for now
config: x86_64-randconfig-a011-20200605 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project ac47588bc4ff5927a01ed6fcd269ce86aba52a7c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout e2079e93f562c7f7a030eb7642017ee5eabaaa10
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/gpu/drm/i915/gt/intel_gt_pm.c:7:
In file included from drivers/gpu/drm/i915/i915_drv.h:36:
In file included from include/linux/io-mapping.h:10:
In file included from include/linux/slab.h:15:
In file included from include/linux/gfp.h:6:
In file included from include/linux/mmzone.h:8:
In file included from include/linux/spinlock.h:51:
In file included from include/linux/preempt.h:78:
In file included from arch/x86/include/asm/preempt.h:7:
In file included from include/linux/thread_info.h:38:
arch/x86/include/asm/thread_info.h:188:13: error: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
oldframe = __builtin_frame_address(1);
^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/thread_info.h:190:11: error: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
frame = __builtin_frame_address(2);
^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/i915/gt/intel_gt_pm.c:7:
In file included from drivers/gpu/drm/i915/i915_drv.h:44:
In file included from include/linux/perf_event.h:49:
include/linux/ftrace.h:692:9: error: calling '__builtin_return_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
addr = CALLER_ADDR1;
^~~~~~~~~~~~
include/linux/ftrace.h:679:38: note: expanded from macro 'CALLER_ADDR1'
#define CALLER_ADDR1 ((unsigned long)ftrace_return_address(1))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:672:36: note: expanded from macro 'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:695:9: error: calling '__builtin_return_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
return CALLER_ADDR2;
^~~~~~~~~~~~
include/linux/ftrace.h:680:38: note: expanded from macro 'CALLER_ADDR2'
#define CALLER_ADDR2 ((unsigned long)ftrace_return_address(2))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:672:36: note: expanded from macro 'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/intel_gt_pm.c:23:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("n");
^~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_gt_pm.c:23:2: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
drivers/gpu/drm/i915/gt/intel_gt_pm.c:65:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("n");
^~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_gt_pm.c:65:2: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
drivers/gpu/drm/i915/gt/intel_gt_pm.c:113:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("n");
^~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_gt_pm.c:113:2: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
7 errors generated.
--
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:134:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:5:
In file included from include/linux/preempt.h:78:
In file included from arch/x86/include/asm/preempt.h:7:
In file included from include/linux/thread_info.h:38:
arch/x86/include/asm/thread_info.h:188:13: error: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
oldframe = __builtin_frame_address(1);
^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/thread_info.h:190:11: error: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
frame = __builtin_frame_address(2);
^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:136:
In file included from drivers/gpu/drm/i915/gem/i915_gem_context.h:10:
In file included from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20:
In file included from drivers/gpu/drm/i915/gt/intel_context_types.h:16:
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:19:
In file included from drivers/gpu/drm/i915/i915_pmu.h:11:
In file included from include/linux/perf_event.h:49:
include/linux/ftrace.h:692:9: error: calling '__builtin_return_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
addr = CALLER_ADDR1;
^~~~~~~~~~~~
include/linux/ftrace.h:679:38: note: expanded from macro 'CALLER_ADDR1'
#define CALLER_ADDR1 ((unsigned long)ftrace_return_address(1))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:672:36: note: expanded from macro 'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:695:9: error: calling '__builtin_return_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
return CALLER_ADDR2;
^~~~~~~~~~~~
include/linux/ftrace.h:680:38: note: expanded from macro 'CALLER_ADDR2'
#define CALLER_ADDR2 ((unsigned long)ftrace_return_address(2))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:672:36: note: expanded from macro 'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:3584:
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:56:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("spinner failed to startn");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/selftests/../i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c:56:4: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/selftests/../i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:3584:
drivers/gpu/drm/i915/gt/selftest_lrc.c:321:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("lo spinner failed to startn");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/selftests/../i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c:321:4: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/selftests/../i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:3584:
drivers/gpu/drm/i915/gt/selftest_lrc.c:338:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("hi spinner failed to startn");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/selftests/../i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c:338:4: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/selftests/../i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:3584:
drivers/gpu/drm/i915/gt/selftest_lrc.c:990:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("lo spinner failed to startn");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/selftests/../i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c:990:4: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/selftests/../i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:3584:
drivers/gpu/drm/i915/gt/selftest_lrc.c:1026:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("hi spinner failed to startn");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/selftests/../i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/gpu/drm/i915/gt/intel_reset.c:7:
In file included from include/linux/sched/mm.h:7:
In file included from include/linux/sched.h:14:
In file included from include/linux/pid.h:5:
In file included from include/linux/rculist.h:11:
In file included from include/linux/rcupdate.h:27:
In file included from include/linux/preempt.h:78:
In file included from arch/x86/include/asm/preempt.h:7:
In file included from include/linux/thread_info.h:38:
arch/x86/include/asm/thread_info.h:188:13: error: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
oldframe = __builtin_frame_address(1);
^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/thread_info.h:190:11: error: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
frame = __builtin_frame_address(2);
^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/i915/gt/intel_reset.c:12:
In file included from drivers/gpu/drm/i915/gem/i915_gem_context.h:10:
In file included from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20:
In file included from drivers/gpu/drm/i915/gt/intel_context_types.h:16:
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:19:
In file included from drivers/gpu/drm/i915/i915_pmu.h:11:
In file included from include/linux/perf_event.h:49:
include/linux/ftrace.h:692:9: error: calling '__builtin_return_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
addr = CALLER_ADDR1;
^~~~~~~~~~~~
include/linux/ftrace.h:679:38: note: expanded from macro 'CALLER_ADDR1'
#define CALLER_ADDR1 ((unsigned long)ftrace_return_address(1))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:672:36: note: expanded from macro 'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:695:9: error: calling '__builtin_return_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
return CALLER_ADDR2;
^~~~~~~~~~~~
include/linux/ftrace.h:680:38: note: expanded from macro 'CALLER_ADDR2'
#define CALLER_ADDR2 ((unsigned long)ftrace_return_address(2))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:672:36: note: expanded from macro 'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/intel_reset.c:820:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("startn");
^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_reset.c:820:2: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
drivers/gpu/drm/i915/gt/intel_reset.c:853:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("endn");
^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_reset.c:853:2: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
drivers/gpu/drm/i915/gt/intel_reset.c:878:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("startn");
^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_reset.c:878:2: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
drivers/gpu/drm/i915/gt/intel_reset.c:923:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("endn");
^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_reset.c:923:2: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:66:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:695:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); ^
include/linux/kernel.h:709:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); ^
8 errors generated.
..
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e2079e93f562c7f7a030eb7642017ee5eabaaa10
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout e2079e93f562c7f7a030eb7642017ee5eabaaa10
vim +23 drivers/gpu/drm/i915/gt/intel_gt_pm.c
79ffac8599c4d8 Chris Wilson 2019-04-24 17
79ffac8599c4d8 Chris Wilson 2019-04-24 18 static int intel_gt_unpark(struct intel_wakeref *wf)
79ffac8599c4d8 Chris Wilson 2019-04-24 19 {
79ffac8599c4d8 Chris Wilson 2019-04-24 20 struct drm_i915_private *i915 =
79ffac8599c4d8 Chris Wilson 2019-04-24 21 container_of(wf, typeof(*i915), gt.wakeref);
79ffac8599c4d8 Chris Wilson 2019-04-24 22
79ffac8599c4d8 Chris Wilson 2019-04-24 @23 GEM_TRACE("\n");
79ffac8599c4d8 Chris Wilson 2019-04-24 24
79ffac8599c4d8 Chris Wilson 2019-04-24 25 /*
79ffac8599c4d8 Chris Wilson 2019-04-24 26 * It seems that the DMC likes to transition between the DC states a lot
79ffac8599c4d8 Chris Wilson 2019-04-24 27 * when there are no connected displays (no active power domains) during
79ffac8599c4d8 Chris Wilson 2019-04-24 28 * command submission.
79ffac8599c4d8 Chris Wilson 2019-04-24 29 *
79ffac8599c4d8 Chris Wilson 2019-04-24 30 * This activity has negative impact on the performance of the chip with
79ffac8599c4d8 Chris Wilson 2019-04-24 31 * huge latencies observed in the interrupt handler and elsewhere.
79ffac8599c4d8 Chris Wilson 2019-04-24 32 *
79ffac8599c4d8 Chris Wilson 2019-04-24 33 * Work around it by grabbing a GT IRQ power domain whilst there is any
79ffac8599c4d8 Chris Wilson 2019-04-24 34 * GT activity, preventing any DC state transitions.
79ffac8599c4d8 Chris Wilson 2019-04-24 35 */
79ffac8599c4d8 Chris Wilson 2019-04-24 36 i915->gt.awake = intel_display_power_get(i915, POWER_DOMAIN_GT_IRQ);
79ffac8599c4d8 Chris Wilson 2019-04-24 37 GEM_BUG_ON(!i915->gt.awake);
79ffac8599c4d8 Chris Wilson 2019-04-24 38
79ffac8599c4d8 Chris Wilson 2019-04-24 39 intel_enable_gt_powersave(i915);
79ffac8599c4d8 Chris Wilson 2019-04-24 40
79ffac8599c4d8 Chris Wilson 2019-04-24 41 i915_update_gfx_val(i915);
79ffac8599c4d8 Chris Wilson 2019-04-24 42 if (INTEL_GEN(i915) >= 6)
79ffac8599c4d8 Chris Wilson 2019-04-24 43 gen6_rps_busy(i915);
79ffac8599c4d8 Chris Wilson 2019-04-24 44
79ffac8599c4d8 Chris Wilson 2019-04-24 45 i915_pmu_gt_unparked(i915);
79ffac8599c4d8 Chris Wilson 2019-04-24 46
79ffac8599c4d8 Chris Wilson 2019-04-24 47 i915_queue_hangcheck(i915);
79ffac8599c4d8 Chris Wilson 2019-04-24 48
79ffac8599c4d8 Chris Wilson 2019-04-24 49 pm_notify(i915, INTEL_GT_UNPARK);
79ffac8599c4d8 Chris Wilson 2019-04-24 50
79ffac8599c4d8 Chris Wilson 2019-04-24 51 return 0;
79ffac8599c4d8 Chris Wilson 2019-04-24 52 }
79ffac8599c4d8 Chris Wilson 2019-04-24 53
:::::: The code at line 23 was first introduced by commit
:::::: 79ffac8599c4d8aa84d313920d3d86d7361c252b drm/i915: Invert the GEM wakeref hierarchy
:::::: TO: Chris Wilson <chris@...is-wilson.co.uk>
:::::: CC: Chris Wilson <chris@...is-wilson.co.uk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (31747 bytes)
Powered by blists - more mailing lists