linux-kernel - Re: [PATCH v2] block: Fix use-after-free in blkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200605111049.GA19604@bombadil.infradead.org>
Date:   Fri, 5 Jun 2020 04:10:49 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Jason Yan <yanaijie@...wei.com>, linux-block@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, hulkci@...wei.com,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>,
        Jens Axboe <axboe@...nel.dk>, Ming Lei <ming.lei@...hat.com>
Subject: Re: [PATCH v2] block: Fix use-after-free in blkdev_get()

On Fri, Jun 05, 2020 at 12:56:45PM +0200, Markus Elfring wrote:
> > A lot of maintainers have blocked Markus and asked him to stop trying
> > to help people write commit message.
> 
> I am trying to contribute a bit of patch review as usual.

Please stop criticising people's commit messages.  Your suggestions
are usually not improvements.

> > Saying "bdev" instead of "block device" is more clear
> 
> I find this view interesting.

Dan is right.

> > so your original message was better.
> 
> Does this feedback include reported spelling mistakes?

You can keep doing that.  But refcount -> reference count is not
particularly interesting.