linux-kernel - Re: [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings documention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200605121118.GC31680@duo.ucw.cz>
Date:   Fri, 5 Jun 2020 14:11:18 +0200
From:   Pavel Machek <pavel@....cz>
To:     Rob Herring <robh@...nel.org>
Cc:     Dan Murphy <dmurphy@...com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        devicetree@...r.kernel.org,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings
 documention


> > > There's no risk because you are supposed to apply both patches. I
> > > don't apply binding patches that are a part of a series like this.
> >
> > Yes, this is always guaranteed to happen, because "git bisect"
> > understand patch series. Oh, wait.
> 
> What!? If the binding patch with the header comes first, how would
> bisect build the driver change without the header?

The driver is already in tree, and includes array of strings. When you
change the define, you need to update the array, too, because you
don't want to have invalid value in there.

> > Patches are supposed to be correct on their own. If your repository
> > filtering can not handle that, you need to fix that...
> 
> I'm just asking you to follow the process that *everyone* else is
> following and works. It's not really about the repository filtering.
> That doesn't care. A binding ABI is defined by the schema and any
> defines it has. That is the logical unit that stands on its own.

It does not work in this case.

Best regards,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)