[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1d95e2f6-7cf8-f0d3-bf8a-54d0a99c9ba1@kernel.dk>
Date: Fri, 5 Jun 2020 07:04:56 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Markus Elfring <Markus.Elfring@....de>,
Matthew Wilcox <willy@...radead.org>,
linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org
Cc: Dan Carpenter <dan.carpenter@...cle.com>,
Jason Yan <yanaijie@...wei.com>, hulkci@...wei.com,
kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
Al Viro <viro@...iv.linux.org.uk>,
Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>,
Ming Lei <ming.lei@...hat.com>
Subject: Re: block: Fix use-after-free in blkdev_get()
On 6/5/20 7:01 AM, Markus Elfring wrote:
>>> The details can vary also for my suggestions.
>>> Would you point any more disagreements out on concrete items?
>>
>> That's exactly the problem with many of your comments.
>> They're vague to the point of unintelligibility.
>
> Was is so vague about possibilities which I point out for patch reviews
> (for example)?
> * Spelling corrections
> * Additional wording alternatives
I'll make this very simple - don't reply making suggestions to commit
messages, ever. The "improvements" aren't usually improvements, and it
causes more confusion for the submitter.
Maintainers generally do change commit messages to improve them, if
needed.
No reply is needed to this e-mail.
--
Jens Axboe
Powered by blists - more mailing lists