linux-kernel - Re: [PATCH 1/3] dma-direct: provide the ability to reserve per-numa CMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Jun 2020 21:57:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Barry Song <song.bao.hua@...ilicon.com>, hch@....de,
        m.szyprowski@...sung.com, robin.murphy@....com,
        catalin.marinas@....com
Cc:     kbuild-all@...ts.01.org, iommu@...ts.linux-foundation.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, Jonathan.Cameron@...wei.com,
        john.garry@...wei.com
Subject: Re: [PATCH 1/3] dma-direct: provide the ability to reserve per-numa
 CMA

Hi Barry,

I love your patch! Perhaps something to improve:

[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on linus/master v5.7]
[cannot apply to next-20200605]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Barry-Song/support-per-numa-CMA-for-ARM-server/20200603-104821
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: i386-randconfig-r016-20200605 (attached as .config)
compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from include/linux/printk.h:326:0,
from include/linux/kernel.h:15,
from include/asm-generic/bug.h:19,
from arch/x86/include/asm/bug.h:83,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/mm.h:9,
from include/linux/memblock.h:13,
from kernel/dma/contiguous.c:21:
kernel/dma/contiguous.c: In function 'dma_pernuma_cma_reserve':
>> include/linux/dynamic_debug.h:82:16: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
static struct _ddebug  __aligned(8)                      ^
include/linux/dynamic_debug.h:123:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
DEFINE_DYNAMIC_DEBUG_METADATA(id, fmt);       ^
include/linux/dynamic_debug.h:143:2: note: in expansion of macro '__dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^
include/linux/dynamic_debug.h:153:2: note: in expansion of macro '_dynamic_func_call'
_dynamic_func_call(fmt, __dynamic_pr_debug,       ^
include/linux/printk.h:330:2: note: in expansion of macro 'dynamic_pr_debug'
dynamic_pr_debug(fmt, ##__VA_ARGS__)
^
kernel/dma/contiguous.c:128:3: note: in expansion of macro 'pr_debug'
pr_debug("%s: reserved %llu MiB on node %dn", __func__,
^

vim +82 include/linux/dynamic_debug.h

923abb9d797ba0 Gal Pressman     2019-05-01  75  
923abb9d797ba0 Gal Pressman     2019-05-01  76  extern __printf(3, 4)
923abb9d797ba0 Gal Pressman     2019-05-01  77  void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
923abb9d797ba0 Gal Pressman     2019-05-01  78  			 const struct ib_device *ibdev,
923abb9d797ba0 Gal Pressman     2019-05-01  79  			 const char *fmt, ...);
923abb9d797ba0 Gal Pressman     2019-05-01  80  
2bdde670beedf7 Rasmus Villemoes 2019-03-07  81  #define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt)		\
c0d2af63786394 Joe Perches      2012-10-18 @82  	static struct _ddebug  __aligned(8)			\
07613b0b5ef857 Jason Baron      2011-10-04  83  	__attribute__((section("__verbose"))) name = {		\
07613b0b5ef857 Jason Baron      2011-10-04  84  		.modname = KBUILD_MODNAME,			\
07613b0b5ef857 Jason Baron      2011-10-04  85  		.function = __func__,				\
07613b0b5ef857 Jason Baron      2011-10-04  86  		.filename = __FILE__,				\
07613b0b5ef857 Jason Baron      2011-10-04  87  		.format = (fmt),				\
07613b0b5ef857 Jason Baron      2011-10-04  88  		.lineno = __LINE__,				\
07613b0b5ef857 Jason Baron      2011-10-04  89  		.flags = _DPRINTK_FLAGS_DEFAULT,		\
2bdde670beedf7 Rasmus Villemoes 2019-03-07  90  		_DPRINTK_KEY_INIT				\
07613b0b5ef857 Jason Baron      2011-10-04  91  	}
07613b0b5ef857 Jason Baron      2011-10-04  92  

:::::: The code at line 82 was first introduced by commit
:::::: c0d2af637863940b1a4fb208224ca7acb905c39f dynamic_debug: Remove unnecessary __used

:::::: TO: Joe Perches <joe@...ches.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (37631 bytes)