linux-kernel - Re: [PATCH] compiler.h: Move instrumentation_begin()/end() into new <linux/instrumentation.h> header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200605143536.GA2577569@gmail.com>
Date:   Fri, 5 Jun 2020 16:35:36 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] compiler.h: Move instrumentation_begin()/end() into new
 <linux/instrumentation.h> header


* Peter Zijlstra <peterz@...radead.org> wrote:

> On Thu, Jun 04, 2020 at 10:19:28AM +0200, Ingo Molnar wrote:
> > The tested v2 version of the patch also needed the include in 
> > asm-generic/bug.h (see the fix attached below), because for 
> > completeness the generic version was annotated as well - even though 
> > only x86 has objtool support for now.
> 
> x86/asm/bug.h includes asm-generic/bug.h.
> 
> x86 uses the generic bug infrastructure.

Yes, indeed. No change to the patch required (other than the 
changelog), both asm-generic/bug.h and x86/asm/bug.h make use of 
instrumentation_begin()/end(), so they both need the #include.

Thanks,

	Ingo