linux-kernel - 答复: [PATCH][v6] KVM: X86: support APERF/MPERF registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 6 Jun 2020 11:53:23 +0000
From:   "Li,Rongqing" <lirongqing@...du.com>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        Jim Mattson <jmattson@...gle.com>
CC:     Xiaoyao Li <xiaoyao.li@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kvm list <kvm@...r.kernel.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        "H . Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>,
        Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Wanpeng Li <wanpengli@...cent.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        "Sean Christopherson" <sean.j.christopherson@...el.com>,
        "wei.huang2@....com" <wei.huang2@....com>
Subject: 答复: [PATCH][v6] KVM: X86: support APERF/MPERF registers



> -----邮件原件-----
> 发件人: Paolo Bonzini [mailto:pbonzini@...hat.com]
> 发送时间: 2020年6月6日 1:22
> 收件人: Jim Mattson <jmattson@...gle.com>
> 抄送: Xiaoyao Li <xiaoyao.li@...el.com>; Li,Rongqing <lirongqing@...du.com>;
> LKML <linux-kernel@...r.kernel.org>; kvm list <kvm@...r.kernel.org>; the
> arch/x86 maintainers <x86@...nel.org>; H . Peter Anvin <hpa@...or.com>;
> Borislav Petkov <bp@...en8.de>; Ingo Molnar <mingo@...hat.com>; Thomas
> Gleixner <tglx@...utronix.de>; Wanpeng Li <wanpengli@...cent.com>; Vitaly
> Kuznetsov <vkuznets@...hat.com>; Sean Christopherson
> <sean.j.christopherson@...el.com>; wei.huang2@....com
> 主题: Re: [PATCH][v6] KVM: X86: support APERF/MPERF registers
> 
> On 05/06/20 19:16, Jim Mattson wrote:
> >>>> @@ -4930,6 +4939,11 @@ int kvm_vm_ioctl_enable_cap(struct kvm
> *kvm,
> >>>>           kvm->arch.exception_payload_enabled = cap->args[0];
> >>>>           r = 0;
> >>>>           break;
> >>>> +    case KVM_CAP_APERFMPERF:
> >>>> +        kvm->arch.aperfmperf_mode =
> >>>> +            boot_cpu_has(X86_FEATURE_APERFMPERF) ?
> cap->args[0] :
> >>>> + 0;
> >>> Shouldn't check whether cap->args[0] is a valid value?
> >> Yes, only valid values should be allowed.
> >>
> >> Also, it should fail with -EINVAL if the host does not have
> >> X86_FEATURE_APERFMPERF.
> > Should enabling/disabling this capability be disallowed once vCPUs
> > have been created?
> >
> 
> That's a good idea, yes.
> 
> Paolo


Thank you all, I will send a new version

-Li