linux-kernel - Re: [PATCH] iio: improve IIO_CONCENTRATION channel type description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 6 Jun 2020 15:46:03 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matt Ranostay <matt.ranostay@...sulko.com>
Cc:     Tomasz Duszynski <tomasz.duszynski@...akon.com>,
        "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Matt Ranostay <mranostay@...il.com>
Subject: Re: [PATCH] iio: improve IIO_CONCENTRATION channel type description

On Mon, 1 Jun 2020 14:19:43 -0700
Matt Ranostay <matt.ranostay@...sulko.com> wrote:

> On Mon, Jun 1, 2020 at 9:18 AM Tomasz Duszynski
> <tomasz.duszynski@...akon.com> wrote:
> >
> > IIO_CONCENTRATION together with INFO_RAW specifier is used for reporting
> > raw concentrations of pollutants. Raw value should be meaningless
> > before being properly scaled. Because of that description shouldn't
> > mention raw value unit whatsoever.
> >
> > Fix this by rephrasing existing description so it follows conventions
> > used throughout IIO ABI docs.  
> 
> Acked-by: Matt Ranostay <matt.ranostay@...sulko.com>

Thanks for tidying that up.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to ignore.

Thanks,

Jonathan

> 
> >
> > Fixes: 8ff6b3bc94930 ("iio: chemical: Add IIO_CONCENTRATION channel type")
> > Signed-off-by: Tomasz Duszynski <tomasz.duszynski@...akon.com>
> > ---
> >  Documentation/ABI/testing/sysfs-bus-iio | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> > index d3e53a6d8331..5c62bfb0f3f5 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -1569,7 +1569,8 @@ What:             /sys/bus/iio/devices/iio:deviceX/in_concentrationX_voc_raw
> >  KernelVersion: 4.3
> >  Contact:       linux-iio@...r.kernel.org
> >  Description:
> > -               Raw (unscaled no offset etc.) percentage reading of a substance.
> > +               Raw (unscaled no offset etc.) reading of a substance. Units
> > +               after application of scale and offset are percents.
> >
> >  What:          /sys/bus/iio/devices/iio:deviceX/in_resistance_raw
> >  What:          /sys/bus/iio/devices/iio:deviceX/in_resistanceX_raw
> > --
> > 2.26.2
> >