[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sat, 06 Jun 2020 15:54:30 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: dmurphy@...com
Cc: andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
kuba@...nel.org, linux@...linux.org.uk, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dp83869: Reset return variable if PHY strap
is read
From: Dan Murphy <dmurphy@...com>
Date: Fri, 5 Jun 2020 15:51:03 -0500
> When the PHY's strap register is read to determine if lane swapping is
> needed the phy_read_mmd returns the value back into the ret variable.
>
> If the call to read the strap fails the failed value is returned. If
> the call to read the strap is successful then ret is possibly set to a
> non-zero positive number. Without reseting the ret value to 0 this will
> cause the parse DT function to return a failure.
>
> Fixes: c4566aec6e808 ("net: phy: dp83869: Update port-mirroring to read straps")
> Signed-off-by: Dan Murphy <dmurphy@...com>
Applied, thank you.
Powered by blists - more mailing lists