linux-kernel - Re: [PATCH v6 2/8] firmware: add offset to request_firmware_into

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 6 Jun 2020 09:34:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     Scott Branden <scott.branden@...adcom.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        David Brown <david.brown@...aro.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Shuah Khan <skhan@...uxfoundation.org>,
        bjorn.andersson@...aro.org, Arnd Bergmann <arnd@...db.de>
Cc:     kbuild-all@...ts.01.org, Mimi Zohar <zohar@...ux.ibm.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/8] firmware: add offset to request_firmware_into_buf

Hi Scott,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20200605]
[cannot apply to char-misc/char-misc-testing driver-core/driver-core-testing kselftest/next integrity/next-integrity linus/master v5.7 v5.7-rc7 v5.7-rc6 v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-partial-read-support-in-request_firmware_into_buf/20200606-070430
base:    af30725c132e2e5c5369b60369ff0771fde7d4ff
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

drivers/i2c/i2c-slave-eeprom.c: In function 'i2c_slave_init_eeprom_data':
>> drivers/i2c/i2c-slave-eeprom.c:131:9: error: too few arguments to function 'request_firmware_into_buf'
131 |   ret = request_firmware_into_buf(&fw, eeprom_data, &client->dev,
|         ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/i2c/i2c-slave-eeprom.c:20:
include/linux/firmware.h:55:5: note: declared here
55 | int request_firmware_into_buf(const struct firmware **firmware_p,
|     ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +/request_firmware_into_buf +131 drivers/i2c/i2c-slave-eeprom.c

389be323cfac38 Wolfram Sang 2014-11-18  122  
e804f0a78e9e43 Björn Ardö   2020-04-24  123  static int i2c_slave_init_eeprom_data(struct eeprom_data *eeprom, struct i2c_client *client,
e804f0a78e9e43 Björn Ardö   2020-04-24  124  				      unsigned int size)
e804f0a78e9e43 Björn Ardö   2020-04-24  125  {
e804f0a78e9e43 Björn Ardö   2020-04-24  126  	const struct firmware *fw;
e804f0a78e9e43 Björn Ardö   2020-04-24  127  	const char *eeprom_data;
e804f0a78e9e43 Björn Ardö   2020-04-24  128  	int ret = device_property_read_string(&client->dev, "firmware-name", &eeprom_data);
e804f0a78e9e43 Björn Ardö   2020-04-24  129  
e804f0a78e9e43 Björn Ardö   2020-04-24  130  	if (!ret) {
e804f0a78e9e43 Björn Ardö   2020-04-24 @131  		ret = request_firmware_into_buf(&fw, eeprom_data, &client->dev,
e804f0a78e9e43 Björn Ardö   2020-04-24  132  						eeprom->buffer, size);
e804f0a78e9e43 Björn Ardö   2020-04-24  133  		if (ret)
e804f0a78e9e43 Björn Ardö   2020-04-24  134  			return ret;
e804f0a78e9e43 Björn Ardö   2020-04-24  135  		release_firmware(fw);
e804f0a78e9e43 Björn Ardö   2020-04-24  136  	} else {
e804f0a78e9e43 Björn Ardö   2020-04-24  137  		/* An empty eeprom typically has all bits set to 1 */
e804f0a78e9e43 Björn Ardö   2020-04-24  138  		memset(eeprom->buffer, 0xff, size);
e804f0a78e9e43 Björn Ardö   2020-04-24  139  	}
e804f0a78e9e43 Björn Ardö   2020-04-24  140  	return 0;
e804f0a78e9e43 Björn Ardö   2020-04-24  141  }
e804f0a78e9e43 Björn Ardö   2020-04-24  142  

:::::: The code at line 131 was first introduced by commit
:::::: e804f0a78e9e43f0105e1bc3e264894b3898e970 i2c: slave-eeprom: Make it possible to pre-load eeprom data

:::::: TO: Björn Ardö <bjorn.ardo@...s.com>
:::::: CC: Wolfram Sang <wsa@...-dreams.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (56373 bytes)