linux-kernel - Re: [PATCH v8 14/16] s390/vfio-ap: handle host AP config change notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 6 Jun 2020 12:31:29 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tony Krowiak <akrowiak@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, freude@...ux.ibm.com,
        borntraeger@...ibm.com, cohuck@...hat.com, mjrosato@...ux.ibm.com,
        pasic@...ux.ibm.com, alex.williamson@...hat.com,
        kwankhede@...dia.com
Subject: Re: [PATCH v8 14/16] s390/vfio-ap: handle host AP config change
 notification

Hi Tony,

I love your patch! Perhaps something to improve:

[auto build test WARNING on kvms390/next]
[also build test WARNING on linus/master v5.7]
[cannot apply to s390/features linux/master next-20200605]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20200606-054350
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/s390/crypto/vfio_ap_ops.c:52:23: warning: no previous prototype for 'vfio_ap_get_mdev_queue' [-Wmissing-prototypes]
52 | struct vfio_ap_queue *vfio_ap_get_mdev_queue(struct ap_matrix_mdev *matrix_mdev,
|                       ^~~~~~~~~~~~~~~~~~~~~~
drivers/s390/crypto/vfio_ap_ops.c:142:24: warning: no previous prototype for 'vfio_ap_irq_disable' [-Wmissing-prototypes]
142 | struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q)
|                        ^~~~~~~~~~~~~~~~~~~
drivers/s390/crypto/vfio_ap_ops.c:1484:5: warning: no previous prototype for 'vfio_ap_mdev_reset_queue' [-Wmissing-prototypes]
1484 | int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
|     ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/s390/crypto/vfio_ap_ops.c:1746:6: warning: no previous prototype for 'vfio_ap_mdev_unassign_apids' [-Wmissing-prototypes]
1746 | bool vfio_ap_mdev_unassign_apids(struct ap_matrix_mdev *matrix_mdev,
|      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/s390/crypto/vfio_ap_ops.c:1779:6: warning: no previous prototype for 'vfio_ap_mdev_unassign_apqis' [-Wmissing-prototypes]
1779 | bool vfio_ap_mdev_unassign_apqis(struct ap_matrix_mdev *matrix_mdev,
|      ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/vfio_ap_mdev_unassign_apids +1746 drivers/s390/crypto/vfio_ap_ops.c

  1733	
  1734	/**
  1735	 * vfio_ap_mdev_unassign_apids
  1736	 *
  1737	 * @matrix_mdev: The matrix mediated device
  1738	 *
  1739	 * @aqm: A bitmap with 256 bits. Each bit in the map represents an APID from 0
  1740	 *	 to 255 (with the leftmost bit corresponding to APID 0).
  1741	 *
  1742	 * Unassigns each APID specified in @aqm that is assigned to the shadow CRYCB
  1743	 * of @matrix_mdev. Returns true if at least one APID is unassigned; otherwise,
  1744	 * returns false.
  1745	 */
> 1746	bool vfio_ap_mdev_unassign_apids(struct ap_matrix_mdev *matrix_mdev,
  1747					 unsigned long *apm_unassign)
  1748	{
  1749		unsigned long apid;
  1750		bool unassigned = false;
  1751	
  1752		/*
  1753		 * If the matrix mdev is not in use by a KVM guest, return indicating
  1754		 * that no APIDs have been unassigned.
  1755		 */
  1756		if (!vfio_ap_mdev_has_crycb(matrix_mdev))
  1757			return false;
  1758	
  1759		for_each_set_bit_inv(apid, apm_unassign, AP_DEVICES) {
  1760			unassigned |= vfio_ap_mdev_unassign_guest_apid(matrix_mdev,
  1761								       apid);
  1762		}
  1763	
  1764		return unassigned;
  1765	}
  1766	
  1767	/**
  1768	 * vfio_ap_mdev_unassign_apqis
  1769	 *
  1770	 * @matrix_mdev: The matrix mediated device
  1771	 *
  1772	 * @aqm: A bitmap with 256 bits. Each bit in the map represents an APQI from 0
  1773	 *	 to 255 (with the leftmost bit corresponding to APQI 0).
  1774	 *
  1775	 * Unassigns each APQI specified in @aqm that is assigned to the shadow CRYCB
  1776	 * of @matrix_mdev. Returns true if at least one APQI is unassigned; otherwise,
  1777	 * returns false.
  1778	 */
> 1779	bool vfio_ap_mdev_unassign_apqis(struct ap_matrix_mdev *matrix_mdev,
  1780					 unsigned long *aqm_unassign)
  1781	{
  1782		unsigned long apqi;
  1783		bool unassigned = false;
  1784	
  1785		/*
  1786		 * If the matrix mdev is not in use by a KVM guest, return indicating
  1787		 * that no APQIs have been unassigned.
  1788		 */
  1789		if (!vfio_ap_mdev_has_crycb(matrix_mdev))
  1790			return false;
  1791	
  1792		for_each_set_bit_inv(apqi, aqm_unassign, AP_DOMAINS) {
  1793			unassigned |= vfio_ap_mdev_unassign_guest_apqi(matrix_mdev,
  1794								       apqi);
  1795		}
  1796	
  1797		return unassigned;
  1798	}
  1799	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (59265 bytes)