linux-kernel - Re: [PATCH 2/3] arm64: mm: reserve hugetlb CMA after numa_init

Open Source and information security mailing list archives

Message-ID: <bad059a3-c564-30a1-198f-1c92de601aed@gmail.com>
Date:   Sun, 7 Jun 2020 22:14:36 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Roman Gushchin <guro@...com>,
        Barry Song <song.bao.hua@...ilicon.com>
Cc:     catalin.marinas@....com, john.garry@...wei.com,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        iommu@...ts.linux-foundation.org, prime.zeng@...ilicon.com,
        Jonathan.Cameron@...wei.com, robin.murphy@....com, hch@....de,
        linux-arm-kernel@...ts.infradead.org, m.szyprowski@...sung.com
Subject: Re: [PATCH 2/3] arm64: mm: reserve hugetlb CMA after numa_init

On 03/06/2020 05:22, Roman Gushchin wrote:
> On Wed, Jun 03, 2020 at 02:42:30PM +1200, Barry Song wrote:
>> hugetlb_cma_reserve() is called at the wrong place. numa_init has not been
>> done yet. so all reserved memory will be located at node0.
>>
>> Cc: Roman Gushchin <guro@...com>
>> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>
> 
> Acked-by: Roman Gushchin <guro@...com>
> 

When did this break or was it broken since the beginning?
In any case, could you provide a "Fixes" tag for it, so that it can easily be
backported to older releases.

Regards,
Matthias

> Thanks!
> 
>> ---
>>  arch/arm64/mm/init.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
>> index e42727e3568e..8f0e70ebb49d 100644
>> --- a/arch/arm64/mm/init.c
>> +++ b/arch/arm64/mm/init.c
>> @@ -458,11 +458,6 @@ void __init arm64_memblock_init(void)
>>  	high_memory = __va(memblock_end_of_DRAM() - 1) + 1;
>>  
>>  	dma_contiguous_reserve(arm64_dma32_phys_limit);
>> -
>> -#ifdef CONFIG_ARM64_4K_PAGES
>> -	hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT);
>> -#endif
>> -
>>  }
>>  
>>  void __init bootmem_init(void)
>> @@ -478,6 +473,11 @@ void __init bootmem_init(void)
>>  	min_low_pfn = min;
>>  
>>  	arm64_numa_init();
>> +
>> +#ifdef CONFIG_ARM64_4K_PAGES
>> +	hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT);
>> +#endif
>> +
>>  	/*
>>  	 * Sparsemem tries to allocate bootmem in memory_present(), so must be
>>  	 * done after the fixed reservations.
>> -- 
>> 2.23.0
>>
>>
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives