linux-kernel - Re: [patch V9 10/39] x86/entry: Provide helpers for execute on irqstack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v9k3jdc6.fsf@nanos.tec.linutronix.de>
Date:   Sun, 07 Jun 2020 13:59:53 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Qian Cai <cai@....pw>, Peter Zijlstra <peterz@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Andrew Cooper <andrew.cooper3@...rix.com>,
        X86 ML <x86@...nel.org>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Brian Gerst <brgerst@...il.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Will Deacon <will@...nel.org>,
        Tom Lendacky <thomas.lendacky@....com>,
        Wei Liu <wei.liu@...nel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        Jason Chen CJ <jason.cj.chen@...el.com>,
        Zhao Yakui <yakui.zhao@...el.com>,
        Alexander Potapenko <glider@...gle.com>
Subject: Re: [patch V9 10/39] x86/entry: Provide helpers for execute on irqstack


CC:+ Alexander

Qian Cai <cai@....pw> writes:
> On Fri, Jun 05, 2020 at 07:36:22PM +0200, Peter Zijlstra wrote:
>> > [ 9371.959858]  asm_call_on_stack+0x12/0x20
>> > asm_call_on_stack at arch/x86/entry/entry_64.S:710
>
> This is one piece of call from the warning call traces that introduced
> by the patch which leads me to revert the commit in the first place. It
> may or may not be the real culprit, but just wanted to highlight it in
> case.

Oh well. The warning is a storage check in the stack depot code,
i.e. stack depot ran out of storage space.

Even if that commit causes stack traces to be larger that revert does
not make any sense at all and handwaving about recursions does not help
either. If that commit introduced a recursion then that would have worse
effects than triggering this warning.

The difference between the interrupt stack switching introduced by this
commit is that it generates another entry in the stack trace compared to
the state before it, which obviously has an effect on the storage
requirements in the stack depot.

Thanks,

        tglx